Feat/329/jsonld validation #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linkedData folder
…d sig types complete
ts/linkedData/index.ts
Outdated
Comment on lines
26
to
29
| { ['@context']: _, ...data }: JsonLdObject, | ||
| context: JsonLdContext, | ||
| ) => canonize(data, { | ||
| expandContext: context, |
There was a problem hiding this comment.
replacing the context can always result in breaking the signature validation. This is why I'm afraid of this context expansion.
There was a problem hiding this comment.
context is provided as a second param so that contexts can be used for objects which may not have their own, e.g. normalizing a json-ld proof. An overload with just one arg which doesn't do this replacement may be good though
There was a problem hiding this comment.
Yes, replacing the context might be a nice feature for now (because may contexts are just garbage), but for long term we should avoid this... I would vote for a second optional parameter to override the context and use the existing one otherwise.
Exulansis
reviewed
Nov 27, 2019
Exulansis
reviewed
Nov 27, 2019
Exulansis
reviewed
Nov 27, 2019
If we rely on TS to infer the type of the defaultContext, we can avoid exporting, the JsonLdContextEntry type, at which point the alias is not needed anymore
Exulansis
reviewed
Nov 27, 2019
Exulansis
requested changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key files are
ts/linkedData/index.tsandts/linkedData/types.ts. Other changes are including jsonLD types in DID doc sections and credential types, and using the digestion/validation functions in DID doc and signed credential classes.