Feat/generic messages #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exulansis
reviewed
May 28, 2020
| @@ -101,7 +101,7 @@ describe('Integration Test - Token interaction flow Credential Offer', () => { | |||
|
|
|||
| it('Should correctly create a credential receive token by service', async () => { | |||
| const decodedCredOfferResponse = JSONWebToken.decode< | |||
| CredentialOfferRequest | |||
There was a problem hiding this comment.
Was the previous / original test broken? The line didn't look right.
Exulansis
reviewed
May 28, 2020
ts/identityWallet/identityWallet.ts
Outdated
|
|
||
| private createCredResp = async ( | ||
| credResp: WithExtraOptions<ICredentialResponseAttrs>, | ||
| private make_req = <T>(type: string) => ( |
Exulansis
reviewed
May 28, 2020
ts/identityWallet/identityWallet.ts
Outdated
|
|
||
| private createCredReceive = async ( | ||
| credReceive: WithExtraOptions<ICredentialsReceiveAttrs>, | ||
| private make_res = <T, R>(type: string) => ( |
make_req -> makeReq, make_res -> makeRes
Merged
Exulansis
added a commit
that referenced
this pull request
Jun 9, 2020
Tests currently fail because of a breaking change in #399. Furthermore, a better API for passing in a custom resolover is needed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes any restrictions imposed by
JSONWebTokenbeing generic overT extends JWTEncodable. These changes are not breaking. In future, the interaction tokens which currently remain in the library can be migrated out in a breaking change.Custom messages can be created with the
IdentityWallet.create.messagepublic function. They will sign and validate like any other.