Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(signing): expose signing on IdentityWallet #410

Closed
wants to merge 1 commit into from
Closed

feat(signing): expose signing on IdentityWallet #410

wants to merge 1 commit into from

Conversation

chunningham
Copy link
Contributor

@chunningham chunningham commented Jun 23, 2020 •
edited
Loading

addresses #409, note that this method may be unsafe and could probably use some way of securing it.

@chunningham chunningham requested a review from Exulansis June 23, 2020 15:01
mnzaki
mnzaki suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@mnzaki mnzaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this being unsafe
I think we should wrap the signed object in some sort of token (JWM? JWT?) and provide the corresponding verification method

@Exulansis
Copy link
Collaborator

Implemented in #424

@Exulansis Exulansis closed this Aug 30, 2020
@Exulansis Exulansis deleted the feat/409/expose_signing branch August 30, 2020 18:43
@Exulansis Exulansis mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnzaki mnzaki mnzaki requested changes

@Exulansis Exulansis Awaiting requested review from Exulansis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunningham @Exulansis @mnzaki