[DRAFT] Backup Encryption #1493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnzaki
reviewed
Oct 23, 2019
| vault: SoftwareKeyProvider, | ||
| derivationArgs: IKeyDerivationArgs, | ||
| ): Promise<string> { | ||
| const data = { |
There was a problem hiding this comment.
About this, can we make things more generic? basically take data directly as any input so that this can be reused in other contexts
There was a problem hiding this comment.
This would mean it becomes a "encryptHybrid" function or similar, right? it could also be moved to the key provider than
There was a problem hiding this comment.
Yes that makes sense, then rename this to something like createWalletBackup which is specific with what to backup, and that simply calls in the key provider to "pack" some data for it
|
The encryption scheme is moved to the jolocom-lib. Needs to be integrated once the lib is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to show Encryption of Backups
Encryption scheme is similar to PGP:
To decrypt:
Advantages: