Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make distclean" removes too much #1167

Closed
sbakker opened this issue Nov 16, 2021 · 0 comments · Fixed by #1169
Closed

"make distclean" removes too much #1167

sbakker opened this issue Nov 16, 2021 · 0 comments · Fixed by #1169

Comments

@sbakker
Copy link

sbakker commented Nov 16, 2021

The distclean target in the release tarball removes files that are part of the tarball (and thus the released source). In other words, if I unpack a tarball and run make distclean, I lose e.g. configure, doc/tig.1, etc. This is especially problematic when trying to build a Debian package: the package builder will run make distclean first. It knows how to run autogen.sh to get configure back, but other files such as the manual pages are lost.

In my understanding, the distclean target should return the tree to the state of the distributed source code. If the distributed source contains a configure script and (generated) man pages, these should not be removed (I would suggest a pristine target for that).

koutcher added a commit to koutcher/tig that referenced this issue Nov 24, 2021
... and replace it with new realclean rule.

Closes jonas#1167
koutcher added a commit to koutcher/tig that referenced this issue Dec 4, 2021
... and replace it with new veryclean rule.

Closes jonas#1167
koutcher added a commit that referenced this issue Jan 4, 2022
... and replace it with new veryclean rule.

Closes #1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant