Add PCRE support #1143
Merged
Add PCRE support #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes jonas#1137
koutcher
force-pushed
the
gh-1137-pcre
branch
from
427748c
to
3d069a8
Compare
jonas
approved these changes
Sep 25, 2021
| view->regex = calloc(1, sizeof(*view->regex)); | ||
| if (!view->regex) | ||
| return ERROR_OUT_OF_MEMORY; | ||
| } | ||
|
|
||
| if (*view->grep) { | ||
| regfree(view->regex); | ||
| *view->grep = 0; |
There was a problem hiding this comment.
Yes, it is more readable to decouple the allocation from regular housekeeping needed when performing a new search.
There was a problem hiding this comment.
Yes and also, maybe I should have mentioned it, PCRE has a slight tendency to segfault when using regfree() on view->regex before regcomp().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1137