Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation between chunks after splitting chunk #1162

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

koutcher
Copy link
Collaborator

Also fix the color of the first split chunk.

Closes #1101

src/stage.c Outdated
@@ -607,6 +610,7 @@ stage_request(struct view *view, enum request request, struct line *line)
return REQ_NONE;
}
stage_split_chunk(view, line);
reset_search(view);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks obviously correct. I guess we could do this on successful splits only, but I don't see a good reason to favor one over the other

diff --git a/src/stage.c b/src/stage.c
index 1b0a92e2..0e869381 100644
--- a/src/stage.c
+++ b/src/stage.c
@@ -404,6 +404,7 @@ stage_split_chunk(struct view *view, struct line *chunk_start)
 	if (chunks) {
 		stage_insert_chunk(view, &header, chunk_start, NULL, NULL);
 		redraw_view(view);
+		reset_search(view);
 		report("Split the chunk in %d", chunks + 1);
 	} else {
 		report("The chunk cannot be split");

Also fix the color of the first split chunk.

Closes jonas#1101
@koutcher koutcher merged commit 1ca8a05 into jonas:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating between chunks doesn't work after splitting chunk
2 participants