Fix reading the value of status.showUntrackedFiles
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
reviewed
Jul 6, 2022
| @@ -1484,7 +1484,7 @@ read_repo_config_option(char *name, size_t namelen, char *value, size_t valuelen | |||
| else if (!strcmp(name, "diff.noprefix")) | |||
| parse_bool(&opt_diff_noprefix, value); | |||
|
|
|||
| else if (!strcmp(name, "status.showUntrackedFiles")) | |||
| else if (!strcmp(name, "status.showuntrackedfiles")) | |||
There was a problem hiding this comment.
nice fix, thanks!
If possible, could you update the commit subject (the first line in the commit message) to mention status.showUntrackedFiles like the PR subject does? The commit subject will appear in the release notes (via git-shortlog).
It seems like `git config --list` prints everything in lowercase. That results in `tig` not recognising the value of `status.showUntrackedFiles` since it's being printed as `status.showuntrackedfiles`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
git config --listprints everything in lowercase. That results intignot recognising the value ofstatus.showUntrackedFilessince it's being printed asstatus.showuntrackedfiles.