Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more fix display non-ascii character. #1301

Merged

Conversation

nonakap
Copy link
Contributor

@nonakap nonakap commented Nov 2, 2023

In addition to the fixes merged in #1299, one more fix was needed.

Before the fix, one test was failing, but after the fix, all tests passed.

      TEST  test/tigrc/view-column-test
            | Failed 1 out of 2 test(s)
            | [FAIL] main-view.screen != expected/main-view.screen
            | diff --git a/expected/main-view.screen b/main-view.screen
            | index 53a71c6..4a307fd 100644
            | --- a/expected/main-view.screen
            | +++ b/main-view.screen
            | @@ -1,15 +1,15 @@
            |    1| 2010-04-07 MPower       Commit 10 E
            |     | 2010-03-29 JTBrahe      Commit 10 D
            | -  3| 2010-03-21 作者         Commit 10 C
            | +  3| 2010-03-21 作           Commit 10 C
            |     | 2010-03-12 RLévesque    Commit 10 B
            |     | 2010-03-04 AUThor       Commit 10 A
            |    6| 2010-02-23 MPower       Commit 9 E
            |     | 2010-02-15 JTBrahe      Commit 9 D
            | -   | 2010-02-06 作者         Commit 9 C
            | +   | 2010-02-06 作           Commit 9 C
            |    9| 2010-01-29 RLévesque    Commit 9 B
            |     | 2010-01-20 AUThor       Commit 9 A
            |     | 2010-01-12 MPower       Commit 8 E
            |   12| 2010-01-03 JTBrahe      Commit 8 D
            | -   | 2009-12-26 作者         Commit 8 C
            | +   | 2009-12-26 作           Commit 8 C
            |     | 2009-12-17 RLévesque    Commit 8 B
            |  [main] 5cb3412a5e06e506840495b91acc885037a48b72 - commit 1 of 50             28%
            |   [OK] stderr assertion

@koutcher koutcher merged commit df07aff into jonas:master Nov 2, 2023
9 checks passed
@nonakap nonakap deleted the one-more-fix-display-non-ascii-character branch November 2, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants