Added support for move to parent in main view. #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -266,7 +266,11 @@ view_driver(struct view *view, enum request request) | |||
| break; | |||
|
|
|||
| case REQ_PARENT: | |||
| report("Moving to parent is not supported by the %s view", view->name); | |||
| if (! strcmp(view->name, "main")) { | |||
| move_view(view, request); | |||
There was a problem hiding this comment.
The changes to support REQ_PARENT should go in src/main.c which is all the main view specific code. There's a main_request method where the case REQ_PARENT and related move_view changes in this patch can exist.
This reverts commit d140e25.
…logic now in main.c We also handle unstaged changes correctly now.
rdnetto
force-pushed
the
move-to-parent-in-main-view
branch
from
f9e732e
to
034d61f
Compare
|
I've moved the code into I also added a special case for treating HEAD as the parent of Unstaged Changes. Sorry about the delay - it's been a hectic week. |
|
Thanks, I ended up massaging the code a bit myself and also added a test and a NEWS entry. |
|
That would be nicer if support 2 direction movement, a really intuitive musle memory when I doing the movement :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #388.