Merge #387

387: Turn deny lints into warn r=jonasbb a=jonasbb

This makes local development easier, since warnings do not fail
compilation.
On CI all warnings are denied anyway, so it will not pass.

bors merge


Co-authored-by: Jonas Bushart <jonas@bushart.org>

CONTRIBUTING.md

@@ -34,6 +34,7 @@ This repository provides a devcontainer setup, which can be used with VS Code or
     * A changelog entry can also be added.
 3. Contributions must pass `cargo clippy` and `cargo fmt`.
     This is also checked by CI and needs to pass before the PR can be merged.
+    The CI does not allow any warnings in the compiled code.
 
 Unless you explicitly state otherwise, any contribution intentionally submitted
 for inclusion in the work by you, as defined in the Apache-2.0 license, shall

serde_with/src/lib.rs

@@ -1,16 +1,17 @@
-#![deny(
+#![warn(
+    clippy::semicolon_if_nothing_returned,
     missing_copy_implementations,
     // missing_crate_level_docs, not available in MSRV
     missing_debug_implementations,
     missing_docs,
+    rust_2018_idioms,
     trivial_casts,
     trivial_numeric_casts,
     unused_extern_crates,
     unused_import_braces,
     unused_qualifications,
     variant_size_differences
 )]
-#![warn(rust_2018_idioms)]
 #![doc(test(attr(forbid(unsafe_code))))]
 #![doc(test(attr(deny(
     missing_copy_implementations,

serde_with_macros/src/lib.rs

@@ -1,17 +1,18 @@
 #![forbid(unsafe_code)]
-#![deny(
+#![warn(
+    clippy::semicolon_if_nothing_returned,
     missing_copy_implementations,
     // missing_crate_level_docs, not available in MSRV
     missing_debug_implementations,
     missing_docs,
+    rust_2018_idioms,
     trivial_casts,
     trivial_numeric_casts,
     unused_extern_crates,
     unused_import_braces,
     unused_qualifications,
     variant_size_differences
 )]
-#![warn(rust_2018_idioms)]
 #![doc(test(attr(forbid(unsafe_code))))]
 #![doc(test(attr(deny(
     missing_copy_implementations,