-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VecSkipError<T> de behavior #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the PR. I left you some notes on the individual parts. Maybe you could also add a tiny snippet to serde_with/src/guide/serde_as_transformations.md That file contains all the available transformations this crate provides.
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 75.43% 75.15% -0.29%
==========================================
Files 47 47
Lines 2842 2858 +16
==========================================
+ Hits 2144 2148 +4
- Misses 698 710 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I updated the documentation in serde_as_transformations.md
a bit. The rest looks good.
bors merge |
Build succeeded: |
hi! This implements #321
I will added doctest & motivating example based on the SO question.
I'm not sure if this should go into the
rust
module. I'm also confused about the T and U parameter names onSerializeAs
impl, which one should go onVecSkipError
.Hope this helped