Provide length when serializing sequence #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 44.41% 44.41%
=======================================
Files 40 40
Lines 3249 3249
=======================================
Hits 1443 1443
Misses 1806 1806 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi, thanks for the PR. The correct fix is to revert #566. I am already on it. I would like to use your test case, since bincode is not a dev-dependency. If you remove the changes to |
bors bot
added a commit
that referenced
this pull request
Mar 10, 2023
572: Revert a breaking change to the Seq trait bound r=jonasbb a=jonasbb The code released in #566 broke multiple thing. It broke compatability with bincode #570 and #571. It broke this atribute combination: ```rust #[serde_as(as = "Seq<(_, Vec<_>)>")] BTreeMap<usize, Vec<usize>>, ``` ``` error[E0277]: the trait bound `serde_with::Seq<(serde_with::Same, std::vec::Vec<serde_with::Same>)>: serde_with::SerializeAs<_>` is not satisfied ``` bors r+ Co-authored-by: Jonas Bushart <jonas@bushart.org>
|
Sounds good. Thank you. I will merge in your changes and remove my fix to keep only the test case. |
Some serializers (e.g. bincode) require a length to serialize a sequence. This test verifies that mapping a map to a sequence when serializing provides the length to the serializer. For jonasbb#570
stephaneyfx
force-pushed
the
provide-length-when-serializing-seq
branch
from
2e1c687 to
0a27e24
Compare
|
Unless I messed up something, this PR should now contain only the test as requested. |
|
Thank you. This looks good. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some serializers (e.g. bincode) require a length to serialize a sequence. This code does what
iterator_len_hintdoes (called bycollect_seqinserde).Resolves #570