Improve error messaged by dropping untagged enums #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untagged enums do not provide good error messages and likely never will, given that there are multiple PRs which are just completely ignored ([serde#2376](serde-rs/serde#2376) and [serde#1544](serde-rs/serde#1544)). Instead using `content::de` the untagged enums can be replaced by custom buffering. The error messages for `OneOrMany` and `PickFirst` now look like this, including the original failure for each variant. ```text OneOrMany could not deserialize any variant: One: invalid type: map, expected u32 Many: invalid type: map, expected a sequence ``` ```text PickFirst could not deserialize any variant: First: invalid type: string "Abc", expected u32 Second: invalid digit found in string ``` The implementations of `VecSkipError` and `DefaultOnError` are updated too, but should not result in any visible changes.
jonasbb
force-pushed
the
drop-most-serde-derives
branch
from
6950301 to
73f9e40
Compare
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 44.41% 46.27% +1.86%
==========================================
Files 40 40
Lines 3249 3315 +66
==========================================
+ Hits 1443 1534 +91
+ Misses 1806 1781 -25
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untagged enums do not provide good error messages and likely never will,
given that there are multiple PRs which are just completely ignored
(serde#2376 and
serde#1544).
Instead using
content::dethe untagged enums can be replaced by custombuffering. The error messages for
OneOrManyandPickFirstnow looklike this, including the original failure for each variant.
The implementations of
VecSkipErrorandDefaultOnErrorare updatedtoo, but should not result in any visible changes.