Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit PendingIntents for notification actions #1190

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/org/runnerup/notification/GpsBoundState.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public GpsBoundState(Context context) {
PendingIntent pi = PendingIntent.getActivity(context, 0, i, intentFlags);

Intent startIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.START_ACTIVITY);
PendingIntent pendingStart = PendingIntent.getBroadcast(
context, 0, startIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/org/runnerup/notification/OngoingState.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ public OngoingState(Formatter formatter, WorkoutInfo workoutInfo, Context contex
PendingIntent pi = PendingIntent.getActivity(context, 0, i, intentFlags);

Intent lapIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.NEW_LAP);
PendingIntent pendingLap = PendingIntent.getBroadcast(
context, 0, lapIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);

Intent pauseIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.PAUSE_RESUME);
PendingIntent pendingPause = PendingIntent.getBroadcast(
context, 0, pauseIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);
Expand Down