-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 4.x Support #176
Django 4.x Support #176
Conversation
- Requirements updated to latest - ugettext - url - USE_TZ
- Sorts imports in urls.py to fix isort issue
Hey @jwedel, It's okay that you don't have all Python versions locally installed, but we should make sure all the checks for all versions pass on CI which they currently don't: https://github.com/jonasundderwolf/django-image-cropping/runs/5033268821?check_suite_focus=true It would be great if you could fix this. |
@anrie As I mentioned already in my PR description, I ran tox and it was successful on Django 2.2. The problem with the build was that the dependency
The build was running on 3.6 and then aborted before running with 3.7 and higher. So, maybe this release with Django 4 support is a good time to cut support at least for Python 3.6? Please, could you let tox run until the end so we can see if it works on Python >= 3.7? EDIT: I will just remove 3.6 from the tox config to see if it would work. If you really want to get it running with Python 3.6, we/I need to find out which dependencies do not work with Python 3.6. and then downgrade. |
- Also removes Pillow dep as it is not required
@anrie
|
Hey @jwedel, the removal of the I am a bit more hesitant when it comes to And |
@anrie no, I just don’t know if other deps also need to be downgraded again. And I’m actually having trouble to install python 3.6 on my Mac, installation/build fails so I cannot really test it locally. So I have to rely on the CI here. Can you somehow enable that the builds run on a commit? This would make the feedback loop a bit shorter for me. I am wondering why the build still builds with python 3.6 even though I have removed it from tox config. But I will add it again and downgrade coverage. Let’s see… |
django-image-cropping/.github/workflows/test_and_coverage.yml Lines 34 to 47 in 36bace0
|
Hey @jwedel, I guess we are close. Alle checks pass, it's just that the tests for 3.6 don't run at the moment: https://github.com/jonasundderwolf/django-image-cropping/runs/5057844917?check_suite_focus=true Looks like your final commit/merge removed 3.6 from the envlist in tox again: https://github.com/jonasundderwolf/django-image-cropping/pull/176/files |
@anrie Damnit, I used some git wizardry to revers parts of my commit and messed it up... Hopefully, it's better now ^^ |
@jwedel Looks better now 👍 Thanks a lot for your contribution! |
This PR fixes #173 and updates to Django 4.0.
Things that have been changed:
I've added a new tox env from Django 4.0 with Python 3.8 + 3.9 as previous versions are not supported anymore.
tox reports:
I don't have all python versions installed, but surprisingly, the tests actually work even on Django 2.2. Didn't expect that.
I also change the purest config as it was pointing to a non existing tests directory. Not sure if this was intentional or not.