Fix for Issue #16, Issue #6, plus some extra #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when I went to create the PR I saw you fixed the I made the commits as targeted as possible so you can just cherrypick if you want. Successful test matrix at https://github.com/whiskeyriver/djantic2/actions/runs/12226405204 |
whiskeyriver
changed the title
* Remove Python 3.8 (EOL) and add Python 3.13. * Add tox matrix for Pydantic 2.8 - 2.10 (<2.8 is uninstallible via poetry) * Update github actions/cache
* Always use `raise from` when reraising * Don't use mutable objects as kwarg defaults * Add missing assert to test case
Pydantic's json schema output changed after 2.8, eliminating the `allOf` wrapping of a single `$ref` element. See: pydantic/pydantic#10029 Here's a hacky way of ensuring tests run between these versions.
* Change `.dict()` to `.model_dump()` * Change `@validator` to `@field_validator` * Change the `Config` inner class to a `ConfigDict`
C405 Unnecessary `list` literal (rewrite as a `set` literal)
FactoryBoy is warning about not implicitly saving after post-generation. This quiets those warnings since these post-generation hooks use `create` explicitly.
|
Thank you. I see some useful stuff here, so I will cherry pick some of it in due time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to fix this one line, and just saw some other stuff that might be a useful contribution so I added it.