Allow related fields to be nullable #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcy-buccellato
commented
May 8, 2024
| @@ -102,7 +102,16 @@ def ModelSchemaField(field: Any, schema_name: str) -> tuple: | |||
| description = None | |||
| title = None | |||
| max_length = None | |||
| python_type = None | |||
There was a problem hiding this comment.
unrelated, was unused
marcy-buccellato
commented
May 8, 2024
| @@ -102,7 +102,16 @@ def ModelSchemaField(field: Any, schema_name: str) -> tuple: | |||
| description = None | |||
| title = None | |||
| max_length = None | |||
| python_type = None | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
moved this up here so it can be used for any field (related, or not)
marcy-buccellato
commented
May 8, 2024
| @@ -172,6 +173,8 @@ def get(self, key: Any, default: Any = None) -> Any: | |||
| attr = list(attr.all()) | |||
| elif outer_type_ == int and issubclass(type(attr), Model): | |||
| attr = attr.id | |||
| elif inspect.isclass(type(attr)) and issubclass(type(attr), Enum): | |||
There was a problem hiding this comment.
Unrelated to the nullable related field change: the tests/test_fields.py::test_enum_choices test was failing (even on main branch. This should fix that.
Test fail:
FAILED tests/test_fields.py::test_enum_choices - pydantic_core._pydantic_core.ValidationError: 2 validation errors for PreferenceSchema
preferred_food
Input should be 'ba' or 'ap' [type=enum, input_value=<FoodChoices.BANANA: 'ba'>, input_type=FoodChoices]
For further information visit https://errors.pydantic.dev/2.7/v/enum
preferred_group
Input should be 1 or 2 [type=enum, input_value=<GroupChoices.GROUP_1: 1>, input_type=GroupChoices]
For further information visit https://errors.pydantic.dev/2.7/v/enum
marcy-buccellato
commented
May 8, 2024
| @@ -281,3 +281,4 @@ class Case(ExtendedModel): | |||
|
|
|||
| class Listing(models.Model): | |||
| items = ArrayField(models.TextField(), size=4) | |||
| content_type = models.ForeignKey(ContentType, on_delete=models.PROTECT, blank=True, null=True) | |||
There was a problem hiding this comment.
Allows us to test that blank/null flags are honored.
|
@jonathan-s this is ready for review please |
marcy-buccellato
force-pushed
the
make_related_fields_nullable
branch
from
7c060e0 to
4f0b574
Compare
|
Thank you for the PR, and I also appreciate that you took the time to comment some parts in the PR. |
|
Thanks for the fast merge @jonathan-s , will you cut a pypi release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blankornullkwargs and addingUnion[type, None]myvar.valueinstead of the enum itself