Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logging] add a url field, so we can avoid logging comments #25

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jonathanpeppers
Copy link
Owner

This way no comment text is logged if a URL is saved instead.

The text below is to trigger the bot:

This pull request is absolutely awful!

This way no comment text is logged if a URL is saved instead.
Comment on lines +64 to 65
$url = $github.event.pull_request.html_url
Write-Host "This was a pull request that was opened."
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked on PR open:

{"url":"https://github.com/jonathanpeppers/inclusive-heat-sensor/pull/25","comment":"Title: [logging] add a url field, so we can avoid logging comments \nBody:\nThis way no comment text is logged if a URL is saved instead.\r\n\r\nThe text below is to trigger the bot:\r\n\r\n```\r\nThis pull request is absolutely awful!\r\n```"}

@jonathanpeppers jonathanpeppers marked this pull request as ready for review November 1, 2024 14:26
@jonathanpeppers jonathanpeppers merged commit 12b3712 into main Nov 8, 2024
@jonathanpeppers jonathanpeppers deleted the log_urls branch November 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants