Add Expirations() and BlockUntilContext(...) to FakeClock. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPJacques
added
release-note/breaking-change
Closed
Closed
DPJacques
force-pushed
the
expirations
branch
2 times, most recently
from
95384d7
to
3c0a225
Compare
- Expirations() allows callers to validate that AfterFunc was not called. - BlockUntilContext(...) was added to fakeClock previously but never exposed in the interface. Oops. - Other NITs: documentation, spellin' We choose to add both functions in the same commit becuase any change to the interface requires toilsome updates by downstream users. Might as well do both functions at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We choose to add both functions in the same commit because any change to the interface requires toilsome updates by downstream users who impelement the interface*. Might as well do both functions at once.
"Go interfaces generally belong in the package that consumes values of the interface type, not a package that implements the interface type." - https://google.github.io/styleguide/go/decisions.html#interfaces
For clarification, the above quote doesn't apply to
clockwork.Clockbecause providing that interface is the intent of this package. However,clockwork.FakeClock's status as an interface means we break downstream users every time we update it :(