Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node_modules #24

Merged
merged 12 commits into from
Sep 5, 2022
Merged

remove node_modules #24

merged 12 commits into from
Sep 5, 2022

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Aug 8, 2022

Many of GitHub's own actions use @vercel/ncc to bundle JavaScript files into a single file. I thought I'd follow this practice, so the node_modules can be removed from the repository.

Copy link
Owner

@joncloud joncloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do some research around @vercel/ncc, and how it works. Overall this looks awesome. If you have any quick links about the tech handy, then I'd be happy to look them over.

.gitignore Outdated Show resolved Hide resolved
dist/index.js Show resolved Hide resolved
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
@joncloud
Copy link
Owner

@idleberg I handled the conflicts in the node.js.yml file, and got the build working. If you could handle the remaining open comments, that'd be awesome!

@joncloud joncloud merged commit df78158 into joncloud:publish Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants