Adds support for running makensis on Linux/macOS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
joncloud
commented
Sep 8, 2020
joncloud
commented
- Creates abstraction for detecting paths by platform
- Updates CI to run on linux and macOS
- Changes arguments to use hyphens for compatibility
* Creates abstraction for detecting paths by platform * Updates CI to run on linux and macOS
|
I validated that makensis 2.51 (fork VixenLights/makensis-action) supports hyphenated arguments just like the current version. |
Closed
Closed
* Replaces paths type with wrapper around makensis executable * Changing plugin calculation to use HDRINFO / NSISDIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.