Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cross-Domain support via JSONP #7

Merged
merged 1 commit into from
Apr 22, 2012
Merged

Conversation

dcartoon
Copy link

@dcartoon dcartoon commented Apr 9, 2012

Hi,

I've committed a change that allows cross-domain refreshes without any additional work by the user. This is done via what's called JSONP(JSON + padding - http://en.wikipedia.org/wiki/JSONP). To do this, I had to change the "get" call to be done via jQuery, since it has built-in support for JSONP(and D3 doesn't, yet).

Graphite has had the corresponding server support for JSONP for the past few months, so no other changes are required for users to take advantage of this feature.

I haven't done any CoffeeScript before, so let me know if there's something that you'd like me to change.

Best Regards,

Dan

Changing the refresh call to use jQuery, which has built-in support for
JSONP, which enables cross-domain requests.  Graphite already supports
this style of request, so it's a little simpler to do this than some of
the alternatives for cross-domain support
@compressed
Copy link

+1. I ran into this today and this fixed my problem!

jondot added a commit that referenced this pull request Apr 22, 2012
Adding Cross-Domain support via JSONP
@jondot jondot merged commit e7082ea into jondot:master Apr 22, 2012
@jondot
Copy link
Owner

jondot commented Apr 22, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants