Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug codecov issues #759

Closed
wants to merge 3 commits into from

Conversation

gtdang
Copy link
Collaborator

@gtdang gtdang commented May 6, 2024

Debugging GitHub actions for uploading codecov report. Unittest actions have been failing since switching to using the codecov-action v4 in #758 .

Codecov uploads have sporadically been failing due to rate-limiting of 'tokenless' uploads. It is not actually tokenless, see explanation below.

If Codecov detects that reports are being uploaded from a fork of an open source repository, Codecov will automatically switch to tokenless uploading...Token-less uploads still use a token to upload to Codecov - just that it's Codecov's Github token instead of the project's own. As such, uploading to Codecov via tokenless (whether it's via forks, or by an older version of the Codecov action) ends up consuming from the shared request pool of a lot of Codecov users, instead of your own. Therefore, there may be cases when uploading to Codecov via tokenless fails because Codecov is being rate limited. Source

This issue has been documented by others:
codecov/feedback#358
codecov/feedback#301
codecov/feedback#112

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.29%. Comparing base (d28ddb7) to head (c084c47).
Report is 36 commits behind head on master.

❗ Current head c084c47 differs from pull request most recent head dec481a. Consider uploading reports for the commit dec481a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #759       +/-   ##
===========================================
- Coverage   92.67%   60.29%   -32.39%     
===========================================
  Files          27       27               
  Lines        4928     4969       +41     
===========================================
- Hits         4567     2996     -1571     
- Misses        361     1973     +1612     
Flag Coverage Δ
unittests 60.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtdang
Copy link
Collaborator Author

gtdang commented May 6, 2024

One option is changing the setting fail_ci_if_error = false. This will not fail the test if the coverage isn't uploaded. There just won't be a coverage report.

@gtdang
Copy link
Collaborator Author

gtdang commented May 6, 2024

Bash implementation doesn't fail the workflow. Seems to be an error during upload and it's requesting a token. I'm not sure if a new report was actually generated...
Screenshot 2024-05-07 at 10 07 13 AM

Bash uploader is being deprecated, though there has been no indication on when they are fully deprecating it.
https://docs.codecov.com/docs/about-the-codecov-bash-uploader

@gtdang
Copy link
Collaborator Author

gtdang commented May 8, 2024

Closing because this was just used to debug workflows.

@gtdang gtdang closed this May 8, 2024
@gtdang gtdang deleted the codecov-upload-fix branch August 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants