Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try_take #7

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat: try_take #7

merged 4 commits into from
Aug 6, 2024

Conversation

marvin-j97
Copy link
Contributor

No description provided.

@marvin-j97 marvin-j97 mentioned this pull request Jul 27, 2024
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Just a few notes.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@marvin-j97 marvin-j97 requested a review from jonhoo August 4, 2024 12:13
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt was unhappy — I'll just fix

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@jonhoo jonhoo merged commit f03afee into jonhoo:main Aug 6, 2024
14 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Aug 6, 2024

Released as 1.2.0 🎉
Thank you!

@marvin-j97 marvin-j97 deleted the feat/try-take branch August 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants