Search for a copy of prettier installed relative to view #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a slight extension of the existing behavior, but adds the ability to use a copy of prettier that is installed relative to the current view.
|
Thanks @nsfmc! I made a few refacotrings; and I'll release it shortly! |
|
thanks @jonlabelle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prettier_cli_path is empty, this adds one more lookup for the
prettierbinary, starting first with the closest ancestor of the view asking to be prettified.In practice this allows projects and monorepos to invoke the version of jsprettier "closest" to the file being modified rather than needing to specify a project-level (or system-level)
prettierbinary.This could potentially be disruptive for monorepos or complex projects that explicitly use the current lookup behavior, so i am 100% ok with this not being used (or the approach being changed). Also the helper fn is a bit awkward, but it's been working for me.
again feel free to close if this is too weird or if you're not down with the approach
take it easy!