-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Elektra specification file #829
Create Elektra specification file #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide example for each key, it makes the spec much easier to read. Also plenty of defaults are missing.
I've added examples and defaults. |
I've incorporated all your suggestions! |
Can you also add CLI arguments/env vars (if needed) before I review it again? |
…p. vidmode/screen.
Yes, I have now added CLI arguments! I haven't found any usage of env vars in redshift. I also made some other minor improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better!
They are now 😉 Please change the top-post to contain an instruction for reviewers. |
…placed by my own work and feedback from @markus2330.
Thanks, I did! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answers
… which automatically picks a suitable option
I believe this is ready to be merged into 814-improve-config as a first step of #814 |
I think this can be closed now as it is superseded by #837? |
Yes, I agree! |
This PR adds an Elektra specification file for redshift (#814).
Reviewers, please take a look at the names of configuration settings.