Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Elektra specification file #829

Closed

Conversation

qwepoizt
Copy link

@qwepoizt qwepoizt commented Jul 21, 2021

This PR adds an Elektra specification file for redshift (#814).

Reviewers, please take a look at the names of configuration settings.

Copy link

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide example for each key, it makes the spec much easier to read. Also plenty of defaults are missing.

src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
@qwepoizt
Copy link
Author

Please provide example for each key, it makes the spec much easier to read. Also plenty of defaults are missing.

I've added examples and defaults.

@qwepoizt
Copy link
Author

I've incorporated all your suggestions!

@markus2330
Copy link

Can you also add CLI arguments/env vars (if needed) before I review it again?

@qwepoizt
Copy link
Author

Yes, I have now added CLI arguments! I haven't found any usage of env vars in redshift. I also made some other minor improvements.

Copy link

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
@markus2330
Copy link

CLI arguments are not yet incorporated.

They are now 😉 Please change the top-post to contain an instruction for reviewers.

@qwepoizt
Copy link
Author

CLI arguments are not yet incorporated.

They are now wink Please change the top-post to contain an instruction for reviewers.

Thanks, I did!

Copy link

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answers

src/elektra/redshift.ini Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
src/elektra/redshift.ini Outdated Show resolved Hide resolved
@qwepoizt qwepoizt changed the base branch from master to 814-improve-config August 5, 2021 09:24
@qwepoizt
Copy link
Author

qwepoizt commented Aug 5, 2021

I believe this is ready to be merged into 814-improve-config as a first step of #814

@markus2330
Copy link

I think this can be closed now as it is superseded by #837?

@qwepoizt
Copy link
Author

I think this can be closed now as it is superseded by #837?

Yes, I agree!

@qwepoizt qwepoizt closed this Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants