Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix *cat inconsistencies #169

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix *cat inconsistencies #169

wants to merge 7 commits into from

Commits on Oct 23, 2022

  1. Change Adjoints to be ComponentArray 

    This PR aims to avoid issues like:
```
using ComponentArrays
A = ComponentMatrix(ones(2, 2), Axis(:a, :b), FlatAxis())
A[:b, :] # works
A'[:, :b] # fails!
```
by wrapping adjoint operations in the underlying data of the ComponentArray structure.

By not having to care about adjoints of ComponentArray, we arguably also reduce overall cognitive load.
    @nrontsis
    nrontsis committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    c1af7db View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Fix tests and cleanup lingering Adj/T references

    @nrontsis
    nrontsis committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0b7a72d View commit details
    Browse the repository at this point in the history

  2. Fix *cat inconsistencies

    @nrontsis
    nrontsis committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8d8bbb6 View commit details
    Browse the repository at this point in the history

  3. Extend tests

    @nrontsis
    nrontsis committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    de8d8ba View commit details
    Browse the repository at this point in the history

  4. Fix offsets computation

    @nrontsis
    nrontsis committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    419105f View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @nrontsis
    nrontsis committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    7bc3561 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Correct bug in duplicate keys detection; introduce test that catches … 

    …the bug
    @nrontsis
    nrontsis committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5f92105 View commit details
    Browse the repository at this point in the history