Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect url validation #119

Open
kevinspacey opened this issue Sep 9, 2016 · 2 comments
Open

Incorrect url validation #119

kevinspacey opened this issue Sep 9, 2016 · 2 comments
Assignees
@jonnnnyw
Labels
bug

Comments

@kevinspacey
Copy link

There is validation error for domain which contains - or _
https://github.com/jonnnnyw/php-phantomjs/blob/master/src/JonnyW/PhantomJs/Http/AbstractRequest.php#L252
@farazirfan47
Copy link

Hi,have you solved this issue?

@jonnnnyw jonnnnyw added the bug label Nov 15, 2016
@jonnnnyw jonnnnyw self-assigned this Nov 15, 2016
@jonnnnyw jonnnnyw mentioned this issue Nov 15, 2016
Closed
jonnnnyw added a commit that referenced this issue Nov 15, 2016
@jonnnnyw
URL validation has been removed as it cannot cover all use cases. A r…
23c9092 
…equest with an invalid URL fails with a status code of 0 - #119
@cinemast
Copy link

@jonnnnyw Could you please create a new release containing this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnnnyw jonnnnyw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinspacey @cinemast @jonnnnyw @farazirfan47