Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle circular references #24

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

emahuni
Copy link

@emahuni emahuni commented Aug 2, 2022

This handles circular references cloning, still working on tests, but it works.

@aaronlippold
Copy link

This will help our team quite a bit. Thanks and can't wait until this is merged

@Dallas62
Copy link

Hi,

This PR add dependencies to lodash.

I don't think it's required. Also, I chose this library to avoid this kind of dependencies.

cloneArrayDeep is merged into cloneObjectDeep, benchmark might be required before merge.

Regards,

@emahuni
Copy link
Author

emahuni commented Aug 26, 2022

Hi,

This PR add dependencies to lodash.

I don't think it's required. Also, I chose this library to avoid this kind of dependencies.

cloneArrayDeep is merged into cloneObjectDeep, benchmark might be required before merge.

Regards,

You are correct about dependencies, I also worry about that, but it's not the entire lodash lib. I didn't add the whole lib, just what was needed. For this reason there is then a room for improvement, but that's the concept overall.

@jonschlinkert
Copy link
Owner

If someone is interested in updating this PR without lodash, I'd be happy to merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants