Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to js-yaml v4, reduce bundle size by ~70% #145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sakulstra
Copy link

it's #137 + the adjusted missing files from the comment

@jonschlinkert would appreciate if you could have a look, the change seems trivial and tests are still passing

@sakulstra sakulstra changed the title fix: adjust missing files feat: update to js-yaml v4, reduce bundle size by ~70% Jun 20, 2022
Copy link
Owner

@jonschlinkert jonschlinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakulstra thanks for the PR.

If you could make the suggested change that would be great. FWIW I was planning on switching to this yaml lib, since it's lighter, well tested, and the code is pretty solid. Since we're doing a major version bump anyway, would you mind trying out that lib instead? And if all tests pass, let's use that library. If not we stick with yaml-js for now until someone has a chance to look into it.

Either way, thanks for taking the time to submit this PR.

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "gray-matter",
"description": "Parse front-matter from a string or file. Fast, reliable and easy to use. Parses YAML front matter by default, but also has support for YAML, JSON, TOML or Coffee Front-Matter, with options to set custom delimiters. Used by metalsmith, assemble, verb and many other projects.",
"version": "4.0.3",
"version": "4.0.4",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. version changes are typically done by maintainers. Also, I personally like to play it safe with major version bumps, especially since incompatible node versions can easily sneak in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk reverted that change 👍

@sakulstra
Copy link
Author

If you could make the suggested change that would be great. FWIW I was planning on switching to this yaml lib, since it's lighter, well tested, and the code is pretty solid.

will do in another pr to not block this one

@sakulstra
Copy link
Author

@jonschlinkert any chance this could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants