Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gray matter loader to related project #82

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

ajaymathur
Copy link
Contributor

This is related to #81

@robertmassaioli robertmassaioli added the docs Updates and improvements to the documentation. label Jan 10, 2019
@robertmassaioli
Copy link
Collaborator

@ajaymathur Can you please improve the README.md file to be more descriptive for gray-matter-loader?

For starters, this sentence could be reworked:

but if you only want to pull gray-matter from markdown

What is "pulling gray-matter from markdown" do you mean "dropping the frontmatter from the markdown content"?

@jonschlinkert It is up to you if you want to include a reference to this repository in the README file. Especially since this package was written by Atlassian to support https://atlaskit.atlassian.com/ documentation and therefore it would be odd for me to just merge it in.

@jonschlinkert
Copy link
Owner

Especially since this package was written by Atlassian to support

I'm totally fine with it, feel free to merge it in once you are happy with it. thanks for asking!

@ajaymathur
Copy link
Contributor Author

I am working on docs of the package. I will update once it is ready. 🙂

@robertmassaioli
Copy link
Collaborator

I am working on docs of the package. I will update once it is ready. 🙂

I'll sync on this next week.

@ajaymathur
Copy link
Contributor Author

Hey @robertmassaioli , I have updated the readme of gray-matter-loader

@robertmassaioli
Copy link
Collaborator

Much better readme. I can see the value clearly now. Merging this in!

@robertmassaioli robertmassaioli merged commit 8a22958 into jonschlinkert:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Updates and improvements to the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants