Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 'bigint', fix deprecated Buffer constructor call #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julianjensen
Copy link

  • add check for type being 'bigint'
  • add test for 'bigint' if BigInt constructor exists (Node version 10+, I think)
  • change new Buffer() to Buffer.from('') in test.js and .verb.md since the constructor call has been deprecated


if ( typeof BigInt === 'function') {
it('should work for BigInt', function () {
assert.strictEqual(kindOf(eval("BigInt(42n)")), 'bigint');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was there for old nodejs versions, this should probably be updated. LTS supports this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants