Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #15 where escaped escape chars were treated as escape chars #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derek-miller
Copy link

No description provided.

@doowb
Copy link
Collaborator

doowb commented Oct 25, 2019

Thanks! I'll take a look at this and get it merged tonight.

@yairk
Copy link

yairk commented Aug 22, 2024

Any chance to get this merged, @doowb, @jonschlinkert ? I was bitten by this too, and really need the fix.

@yairk
Copy link

yairk commented Aug 23, 2024

Reviewing the pull request again, I suspect that the code counts the number of backslashes before the opening quote, and uses this to decide if the closing quote candidate should be respected.

In other words, given the string '\\\\"hello.world\\"', the code will (correctly) decide that the opening quotes are not escaped, but will wrongly decide that the closing quotes are escaped because it doesn't count the number of backslashes before the closing quote.

@derek-miller - I know it's been a while, but did this code work for you?
@doowb , @jonschlinkert - If you agree, I can submit a corrected PR if there's interest from your side and you're still maintaining this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants