Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: bb-jump: quickly navigate directly to any bm #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Boruch-Baum
Copy link

  • Inspired by function bookmark-jump from emacs-core package bookmark.el

  • List of bookmarks are presented as mini-buffer completion candidates

  • Presentation includes enhanced fontification of each bookmark's file name and line number.

@joodland
Copy link
Owner

joodland commented May 5, 2021

I am not getting this to work properly:

  • No auto-complete in the minibuffer just a history list to scroll up or down.
  • Jumping to a bookmark in a buffer other than the current buffer does not work.

Isn't this use-case already solved by the functionality of bm-show and bm-show-all?

@Boruch-Baum
Copy link
Author

Boruch-Baum commented May 5, 2021 via email

"Jump to bookmark: "
(mapcar 'car candidates) nil t)))
(when (setq decision (assoc decision candidates))
(goto-char (overlay-start (cadr decision))))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the bookmark is not available, but I don't like that jumping to a bookmark is done without using bm-goto() since there are more things happening in addition to the jump.

@Boruch-Baum
Copy link
Author

Boruch-Baum commented May 6, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants