Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Require positive tests on PHP 8.0, additionally test PHP 8.1 #39

Merged
merged 6 commits into from
Sep 23, 2021

Conversation

nibra
Copy link
Contributor

@nibra nibra commented Sep 23, 2021

Summary of Changes

Drone configuration

  • Require tests on PHP 8.0 to pass
  • Additionally test on PHP 8.1

Testing Instructions

None

Documentation Changes Required

None

@nibra nibra merged commit 9d60fbf into joomla-framework:2.0-dev Sep 23, 2021
@nibra nibra deleted the php8 branch September 23, 2021 16:44
@escopecz escopecz mentioned this pull request Jan 7, 2022
8 tasks
@r-martins
Copy link

I may be testing in a different way from you guys, but using PHPCompatibility tests on tag 2.0.0 fails even for PHP 7.4.

$ phpcs -p ./src --standard=PHPCompatibility --runtime-set testVersion 7.4

E...W...................EE 26 / 26 (100%)



FILE: /Users/martins/temporarios/joomla-string/src/Normalise.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | 'string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/martins/temporarios/joomla-string/src/phputf8/utf8.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 45 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
-----------------------------------------------------------------------------------


FILE: /Users/martins/temporarios/joomla-string/src/StringHelper.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | 'string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/martins/temporarios/joomla-string/src/Inflector.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | 'string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 766ms; Memory: 8MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants