Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated namespaces to joomla\jorobo #10

Merged
merged 3 commits into from
Feb 1, 2016

Conversation

yvesh
Copy link
Contributor

@yvesh yvesh commented Nov 6, 2015

Changed jorobo namespace from \JBuild to \joomla\jorobo

Additional changes:

  • Changed jbuild.ini to jorobo.ini
  • CS

@yvesh yvesh self-assigned this Nov 12, 2015
@yvesh
Copy link
Contributor Author

yvesh commented Dec 9, 2015

Before merging we need a PR for this in weblinks. Else this is going to break the build / tests of it!

@wilsonge
Copy link
Contributor

wilsonge commented Dec 9, 2015

Few small things. I know this is the joomla-projects repo but can we keep the namespaces for everything in this project as just Joomla please? Also as it's best practice to have capital letters (I know PSR-4 doesn't explicitly state it) can it be Joomla\Jorobo. Thanks :)

@yvesh
Copy link
Contributor Author

yvesh commented Dec 11, 2015

@wilsonge Okay going to update the PR. I followed the style in joomla/robo. Thanks :)

javigomez added a commit that referenced this pull request Feb 1, 2016
Updated namespaces to joomla_projects\jorobo
@javigomez javigomez merged commit 5deb520 into joomla-projects:master Feb 1, 2016
@javigomez javigomez changed the title Updated namespaces to joomla_projects\jorobo Updated namespaces to joomla\jorobo Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants