Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #22

Merged
merged 6 commits into from
Sep 14, 2016
Merged

Some improvements #22

merged 6 commits into from
Sep 14, 2016

Conversation

shanginn
Copy link
Contributor

@shanginn shanginn commented Aug 3, 2016

Hello there! Great project, thank you for this tasks :)
I started using robo for my own component, and noticed, that some functional is missing, so I added it.
Here is what I have changed:

  • Component build:
    • Added media check
    • Small fixes
  • Language build:
    • Checks for all languages, not only english
  • Library build:
    • I'm not sure, but as far as I know Libraries only have backend languages, so I changed it
    • And some small fixes
  • Package deploy:
    • Add all languages
    • Added library build&&deploy
    • Now package can include script.php - package installation file, located at src/administrator/manifests/PKG_NAME/script.php

That's it. Feel free to ask me any questions. Hope you'll like it :)

@yvesh
Copy link
Contributor

yvesh commented Aug 4, 2016

@shanginn First thank you for your contribution :-)

I'm not sure, but as far as I know Libraries only have backend languages, so I changed it

No, that were plugins :-) Please keep the frontend languages, else you break B/C for some extensions using JoRobo.

@shanginn
Copy link
Contributor Author

shanginn commented Aug 4, 2016

@yvesh oh, okay :)
is it alright if I change ##MEDIAPACKAGEFILES## to ##MEDIA_FILES## and the same with languages, change them to ##BACKEND_LANGUAGE_FILES## and ##FRONTEND_LANGUAGE_FILES## instead of whatever it was before?
The same names used in the Component extension, so it is more unified

@yvesh
Copy link
Contributor

yvesh commented Aug 4, 2016

sure that's fine :-)

@rdeutz rdeutz merged commit ef69aab into joomla-projects:develop Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants