-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu Items overview - Filter on Component - v2 #28832
Menu Items overview - Filter on Component - v2 #28832
Conversation
Co-Authored-By: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on aaf4ce3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
1 similar comment
I have tested this item ✅ successfully on aaf4ce3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
@pe7er look at https://github.com/pe7er/joomla-cms/pull/1it use the prepared statement for the new where clause |
sql prepared statement
Wouldn't it be more obvious to filter by menu item type than component? |
I have tested this item ✅ successfully on d951e96 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
Back to pending after recent change for prepared statements. One more tester needed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
I have tested this item ✅ successfully on d951e96 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
Back to RTC after 2 good tests. But could you check @wilsonge 's comment "Wouldn't it be more obvious to filter by menu item type than component?"? Seems to be a valid question to me. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
@pe7er Could you check George's comment above? I think it is a valid question. When fitering by the type of menu item we may achieve nearly the same result, because the item types are connected to the component, and it might also be easier. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
…-overview-filter-on-component
@richard67 @wilsonge I have changed my PR:
Before the change the dropdown would be: After the change the dropdown looks like: Note: I've added a |
@pe7er Should the label then still be "- Select Component -"? |
@richard67 yes, I think so. Or do you have a suggestion for something better? |
I would like to add that when a component is uninstalled, the menu items created with that component become 'orphan' and are no longer 'filtrable'. I would assume this as 'normal' behavior. @pjdevries would you mind recording your test in the issue tracker? Thank you. |
This PR requires updated documentation for the online help such as the one found at https://help.joomla.org/proxy?keyref=Help42:Menus:_Items Thank you! |
I have tested this item ✅ successfully on 40e3f99 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
Great PR, thank you Peter @pe7er for this feature and for all to comment and help make this a good addition. Peter, do you need help with documentation? |
administrator/components/com_menus/src/Field/MenuItemByComponentField.php
Outdated
Show resolved
Hide resolved
administrator/components/com_menus/src/Field/MenuItemByComponentField.php
Outdated
Show resolved
Hide resolved
administrator/components/com_menus/src/Field/MenuItemByComponentField.php
Outdated
Show resolved
Hide resolved
administrator/components/com_menus/src/Field/MenuItemByComponentField.php
Outdated
Show resolved
Hide resolved
…ntField.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
…ntField.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
…ntField.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
…ntField.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
I have tested this item ✅ successfully on 40e3f99 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28832. |
Hello Peter @pe7er, do you need help with documentation? Would love to sere this PR merged soon. |
Documentation added ✔️ (https://docs.joomla.org/Help4.x:Menus:_Items) |
Thank you Peter @pe7er for this PR! |
Pull Request to add a Component filter to the "Menus: Items" overview.
It's PR #24665 re-done for the current Joomla 4.2-dev.
Summary of Changes
This PR adds a Component filter to the menu items overview so that you can filter on specific Components.
Before PR
Testing Instructions
Expected result
The list of menu items should be filtered to only show menu items to views of that selected Component.
After PR
A new Filter field should be available:
The new filter fields enables you to filter on Menu Items of type = Articles (com_content)
The new filter fields enables you to filter on Menu Items of type = Contacts (com_contact)