[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 #36777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`
|
I have tested this item ✅ successfully on 1a1f786 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777. |
|
I have tested this item ✅ successfully on 1a1f786 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777. |
|
R2C This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777. |
zero-24
reviewed
Jan 23, 2022
richard67
added
the
Updates Requested
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
|
Test: I tested the proposed change and it fixes the issue same as my orignal fix proposal. |
|
Merging thanks |
Quy
removed
the
Updates Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # none, directly fixed here.
Summary of Changes
Fixes
Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258Testing Instructions
Obvious source-code review should be enough.
Otherwise go into admin with PHP 8.1 and debug on, with deprecation warnings turned on.
Actual result BEFORE applying this Pull Request
Displays warning
Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258Expected result AFTER applying this Pull Request
warning disappears.
Documentation Changes Required
None.