Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] [PHP 8.1] Fixing mod_search Passing null to type string #36792

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

beat
Copy link
Contributor

@beat beat commented Jan 22, 2022

Pull Request for Issue # none

Summary of Changes

Fixes Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44

Testing Instructions

Code review is enough.

But to reproduce, use PHP 8.1 with Debug ON and all (incl. deprecation) php warnings on, in fronted see warning with mod_search enabled.

Actual result BEFORE applying this Pull Request

Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44

Expected result AFTER applying this Pull Request

that warning disappears

Documentation Changes Required

none.

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Jan 23, 2022
@alikon
Copy link
Contributor

alikon commented Jan 23, 2022

I have tested this item ✅ successfully on 60cbce4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 60cbce4

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 23, 2022
@zero-24
Copy link
Contributor

zero-24 commented Jan 23, 2022

Merging thanks

@zero-24 zero-24 merged commit c0286f0 into joomla:3.10-dev Jan 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 23, 2022
@Quy Quy added this to the Joomla 3.10.6 milestone Jan 23, 2022
@MrTJTwee
Copy link

I have tested this item ✅ successfully on 60cbce4

Thanks. Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants