Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Smart Search: Allow to select which taxonomies to index #36867

Merged
merged 50 commits into from
May 29, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 27, 2022

Pull Request for Issue #26233.

Summary of Changes

This allows you to set which taxonomies should be indexed by a finder plugin.

Testing Instructions

  1. Setup a site with some content.
  2. Disable all finder plugins except for one (to test them one by one)
  3. Edit the last active finder plugin and select which taxonomies to index from the list of checkboxes.
  4. Run the indexer

Actual result BEFORE applying this Pull Request

All taxonomies were indexed each time.

Expected result AFTER applying this Pull Request

Only the selected taxonomies are indexed.

Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Hackwar and others added 3 commits January 27, 2022 10:17
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
plugins/finder/tags/tags.php Outdated Show resolved Hide resolved
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 6, 2023
@Hackwar Hackwar changed the base branch from 4.3-dev to 4.4-dev March 23, 2023 10:34
@Hackwar Hackwar changed the title [4.3] Smart Search: Allow to select which taxonomies to index [4.4] Smart Search: Allow to select which taxonomies to index Mar 23, 2023
@Quy Quy removed the PR-4.3-dev label Mar 23, 2023
@laoneo
Copy link
Member

laoneo commented Mar 28, 2023

Thank you for your contribution, unfortunately the 4.4-dev branch doesn't get new features. When #40181 is merged this pr should be rebased to 5.0-dev. Thanks for understanding.

@Hackwar Hackwar changed the base branch from 4.4-dev to 5.0-dev March 28, 2023 08:11
@Hackwar Hackwar changed the title [4.4] Smart Search: Allow to select which taxonomies to index [5.0] Smart Search: Allow to select which taxonomies to index Mar 28, 2023
@Quy Quy removed the PR-4.4-dev label Mar 28, 2023
@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner
Copy link
Member

How would this look like for custom fields (in the future)? Would we add this option as custom field attribute?

@Hackwar
Copy link
Member Author

Hackwar commented Apr 7, 2023

#38650 adds options to set if a custom field should be indexed as text or taxonomy or none.

@Hackwar Hackwar closed this Apr 18, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 18, 2023
@richard67
Copy link
Member

Why closed? Should we reopen the original issue?

@Hackwar Hackwar reopened this Apr 18, 2023
@HLeithner HLeithner merged commit 50c27fb into joomla:5.0-dev May 29, 2023
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner added this to the Joomla! 5.0 milestone May 29, 2023
@HLeithner
Copy link
Member

We need documentation for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.