Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] [PHP 8.1] Fix Deprecated notice: strtolower(): Passing null to string in components/com_ajax/ajax.php on line 39 #37007

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

beat
Copy link
Contributor

@beat beat commented Feb 11, 2022

Pull Request for Issue # none

Summary of Changes

Fixes Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

Testing Instructions

Code-review or

With PHP 8.1 try accessing:
http://localhost/.../index.php/component/ajax/?plugin=RunSchedulerWebcron&group=system&hash=ERoRNEvIxx8cLCIho0T2

(without &format=raw)

Actual result BEFORE applying this Pull Request

Error Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

Expected result AFTER applying this Pull Request

This error disappears.

Documentation Changes Required

None.

@beat beat changed the title [PHP 8.1] Fix Deprecated notice: strtolower(): Passing null to string in components/com_ajax/ajax.php on line 39 [4.1] [PHP 8.1] Fix Deprecated notice: strtolower(): Passing null to string in components/com_ajax/ajax.php on line 39 Feb 11, 2022
@Quy Quy added the PHP 8.x PHP 8.x deprecated issues label Feb 11, 2022
@toivo
Copy link
Contributor

toivo commented Feb 12, 2022

I have tested this item ✅ successfully on e647a52

Tested successfully in Joomla 4.1.0-rc5-dev in Wampserver 3.2.7 using PHP 8.1.2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37007.

@alikon
Copy link
Contributor

alikon commented Feb 12, 2022

I have tested this item ✅ successfully on e647a52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37007.

@alikon
Copy link
Contributor

alikon commented Feb 12, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37007.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2022
… is deprecated in components/com_ajax/ajax.php on line 39

Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39
@brianteeman
Copy link
Contributor

@beat unless there are conflicts you dont need to update your branch. Everytime you push a commit it resets the count of testers

@beat
Copy link
Contributor Author

beat commented Feb 15, 2022

Thank you @brianteeman ! That was unexpected to me, as it's just a merge of the target that, if mergeable, doesn't get new tests. Additionally, github wasn't flagging it as automatically mergeable. Anyway, now I know (until I forget about it lol)!

@bembelimen bembelimen merged commit 03c0fc6 into joomla:4.1-dev Feb 22, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants