-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Update Codemirror to 6-th version #41070
Conversation
When you are using codemirror as the content editor and go to full screen mode and then try to use one of the xtd-editor buttons then you get stuck in a modal/backdrop loop |
When using codemirror in the template manager if you toggle the "Show Original File" then you get a js error in the console
|
Co-authored-by: Brian Teeman <brian@teeman.net>
yeah, it a bootstrap "bug", it does not allow modal in container with fixed position... |
The bugs is fixed, should work now, the modal and "Show Original File" |
I have tested this item ✅ successfully on a8f84f2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41070. |
Thanks I'm merging this for now so we have it in alpha 3 and people can give some feedback. |
…a#41211) * Add deleted files and folders from PRs joomla#40664 , joomla#41070 and joomla#41101 * Remove false alarm due to missing upmerge of PR joomla#41101
Summary of Changes
Update Codemirror 6
I removed half of old parameters from plugin configuration.
But I think no one will notice.
Testing Instructions
Apply patch, run
npm install
Change default editor to codemirror, make sure editing still works
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Links