Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Update Codemirror to 6-th version #41070

Merged
merged 60 commits into from
Jul 17, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 27, 2023

Summary of Changes

Update Codemirror 6

I removed half of old parameters from plugin configuration.
But I think no one will notice.

Testing Instructions

Apply patch, run npm install
Change default editor to codemirror, make sure editing still works

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

Links

build/build.js Outdated Show resolved Hide resolved
@brianteeman
Copy link
Contributor

When you are using codemirror as the content editor and go to full screen mode and then try to use one of the xtd-editor buttons then you get stuck in a modal/backdrop loop

@brianteeman
Copy link
Contributor

When using codemirror in the template manager if you toggle the "Show Original File" then you get a js error in the console


admin-template-toggle-switch.min.js?ac1f2cda16f61510b1b3bca453fe1fcf:1 Uncaught TypeError: Joomla.editors.instances.jform_core.refresh is not a function
    at HTMLInputElement.n (admin-template-toggle-switch.min.js?ac1f2cda16f61510b1b3bca453fe1fcf:1:1079)
n @ admin-template-toggle-switch.min.js?ac1f2cda16f61510b1b3bca453fe1fcf:1

@Fedik
Copy link
Member Author

Fedik commented Jul 17, 2023

... then you get stuck in a modal/backdrop loop

yeah, it a bootstrap "bug", it does not allow modal in container with fixed position...
Need to look, in past there was no xtd-buttons when codemirror in full screen, but I think it is nice to have.

@Fedik
Copy link
Member Author

Fedik commented Jul 17, 2023

The bugs is fixed, should work now, the modal and "Show Original File"

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a8f84f2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41070.

@HLeithner HLeithner merged commit eac7fd7 into joomla:5.0-dev Jul 17, 2023
@HLeithner
Copy link
Member

Thanks I'm merging this for now so we have it in alpha 3 and people can give some feedback.

@Fedik Fedik deleted the codemirror6 branch July 17, 2023 13:05
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
HLeithner pushed a commit that referenced this pull request Jul 24, 2023
* Add deleted files and folders from PRs #40664 , #41070 and #41101

* Remove false alarm due to missing upmerge of PR #41101
heelc29 added a commit to heelc29/joomla that referenced this pull request Aug 13, 2023
heelc29 added a commit to heelc29/joomla that referenced this pull request Aug 13, 2023
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
…a#41211)

* Add deleted files and folders from PRs joomla#40664 , joomla#41070 and joomla#41101

* Remove false alarm due to missing upmerge of PR joomla#41101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP Documentation Required Feature Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants