-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Select Schedule Task css #41871
Conversation
The select task view is the same as the select module view except it uses its own css file with invalid css. This PR changes that so that it uses an scss file in exactly the same way as com_modules. This removes the invalid css and makes it more maintainable.
removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section. |
sorry - not sure exactly what you are asking for here |
more or like a copy of that what the compat plugin does for the es5 assets. new json file with the removed parts from this pr and loading the new json file when the es5 assets are loaded |
sorry I think I understand what you mean but I dont know what to put in place of the xxxxxxxxxxx
|
…duler" This reverts commit 3bb1df2.
@brianteeman Shall I help with the merge conflicts? |
This reverts commit a9e3bedc2cc97deb806be1138fe0402e30c2e932.
@richard67 yes please - not in the right headspace today to resolve it |
Any help with this would be appreciated as well #41871 (comment) |
I think like this
|
@brianteeman Conflicts resolved. With the other thing I don't know yet if I can help. |
System tests will fail in Drone due to unrelated reasons, see #41938 . |
thanks @richard67 @wilsonge yes I assumed that in my post just dont have a clue what to put in place of the xxxxxxxxxx in my code snippet |
Create a new parameter in the plugin. Doesn't make sense to mix this with the existing es5 assets |
thats what i am doing arent i? just need to know what to put instead of the xxxxxxxxxxx /me confused |
https://github.com/joomla/joomla-cms/blob/5.0-dev/plugins/behaviour/compat/compat.xml#L36-L47 new param in here to match and then pick a name. |
Hopefully I just got it right now. As soon as you mentioned the xml it started to click |
Looks fine to me |
thanks |
The select task view is the same as the select module view except it uses its own css file with invalid css.
This PR changes that so that it uses an scss file in exactly the same way as com_modules. This also removes the invalid css and makes it more maintainable. There will be no visible change
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: will be added when merged
No documentation changes for manual.joomla.org needed