Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Events] Use event classes for Actionlog plugins #43639

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 9, 2024

Summary of Changes

Update actionlog plugins to use SubscriberInterface and event classes.
And adding a couple missing events for User pw reset.

Testing Instructions

Check that actionlog works as before.
Test User reset requests, should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Jul 23, 2024

I have tested this item ✅ successfully on d6ff121

I was able to test this successfully.

I did an incorrect login which ended up in the action log, I did a full user reset which works perfectly (but no trace in the logs which I believe is standard).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43639.

@rdeutz
Copy link
Contributor

rdeutz commented Jul 24, 2024

LGTM on Code Review

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Jul 24, 2024
@Hackwar Hackwar enabled auto-merge (squash) July 26, 2024 13:31
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 26, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 26, 2024

Thank you @Fedik for your contribution! 😊

@Hackwar Hackwar merged commit 24d5894 into joomla:5.2-dev Jul 26, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@Fedik Fedik deleted the plg-event-actionlog branch July 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants