[4.x] Fix com_content batch modal button logic #43651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 08b5017 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43651. |
1 similar comment
|
I have tested this item ✅ successfully on 08b5017 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43651. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43651. |
|
Thank you! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Fix com_content articles batch modal button logic * remove check completly ---------
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Fix com_content articles batch modal button logic * remove check completly ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The ACL check for the batch toolbar button in the com_content articles backend view has been fixed. So far it was checking for the transition execution permission of com_workflows even if the workflow wasn't enabled at all.
Testing Instructions
Install a 4.x site, create an "Administrator" level user account, navigate to the article list, create at least one example article. Select that article in the list view, hit the "Actions" button in the toolbar and look for the "batch" option in the submenu.
Actual result BEFORE applying this Pull Request
Batch option missing
Expected result AFTER applying this Pull Request
Batch option available
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[x ] No documentation changes for manual.joomla.org needed