Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Added Exception Message to Taks Notification Email #43666

Open
wants to merge 14 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brbrbr
Copy link

@brbrbr brbrbr commented Jun 17, 2024

Summary of Changes

The email sent by the system plugin task notification contains very little useful information. This adjustment adds the Exception message to the emails.
The emails point to the Joomla! backend for more information, however there is no info in the dashboard since the taskcontent is not stored and the logs are well hidden.

Testing Instructions

Enable email notifications for failure for any active task for example in sessiongc. Is enabled by default.

Throw an exception in that task, for example:
` private function sessionGC(ExecuteTaskEvent $event): int
{

    throw new \Exception('test');

...
`
execute the task

Actual result BEFORE applying this Pull Request

Email with little information

Expected result AFTER applying this Pull Request

Email with the exception message

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Jun 17, 2024
@brianteeman
Copy link
Contributor

If the email now includes the message is there any point in telling someone to go to the joomla admin etc?

@brbrbr
Copy link
Author

brbrbr commented Jun 18, 2024

If the email now includes the message is there any point in telling someone to go to the joomla admin etc?

Good point,

Actually, in the current situation, there is also no point of telling someone to go to the admin. Since there is no information there.
(unless you have an extension to view the logs).

Should I include the debug trace in the email as well? That one is neither stored nor logged.

Bram

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@LadySolveig LadySolveig changed the base branch from 5.1-dev to 5.2-dev July 3, 2024 11:27
@LadySolveig
Copy link
Contributor

Thank you @brbrbr for your work!
I've rebased this PR to 5.2 as an improvement. 5.1 only gets bugfixes.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title Added Exception Message to Taks Notification Email [5.3] Added Exception Message to Taks Notification Email Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants