Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #43668 PluginAdapter checkExistingExtension does not load plugin #43672

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from

Conversation

svanschu
Copy link
Contributor

Pull Request for Issue #43668 .

Summary of Changes

Do the same extension load in the checkExistingExtension as for InstallerAdapter

Testing Instructions

Try to install a plugin as update and get the information of the current installed plugin in the preflight.

For example

public function preflight(string $type, InstallerAdapter $parent): bool
{
    $cache         = new Registry($parent->extension->manifest_cache);
    $this->oldVersion = $cache->get('version');

    return true;
}

Actual result BEFORE applying this Pull Request

$this->oldVersion = null

Expected result AFTER applying this Pull Request

$this->oldVersion = <the actual currently installed version>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

…lugin

Signed-off-by: Sven Schultschik <sven@schultschik.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants