Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Created translatable strings for LocalAdapter.php "code review" #43694

Merged
merged 17 commits into from
Sep 18, 2024

Conversation

webmasterab
Copy link
Contributor

@webmasterab webmasterab commented Jun 22, 2024

Pull Request for Issue # .

This is new to me.
If I did it wrong please let me know.

Summary of Changes
I changed fixed translation to translatable strings

Testing Instructions

"code review"
It's only changed in the code.
I converted the fixed value of the error message into a translatable string

Actual result BEFORE applying this Pull Request
In localAdapter.php there was untranslatable text.

Expected result AFTER applying this Pull Request
In localAdapter.php the text is now translatable using string

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [X ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ X] No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels Jun 22, 2024
@webmasterab webmasterab changed the title 4.4-dev Created translatable strings for LocalAdapter.php Jun 22, 2024
language/en-GB/com_media.ini Outdated Show resolved Hide resolved
webmasterab and others added 2 commits June 22, 2024 17:48
Thanks

Co-authored-by: Quy <quy@nomonkeybiz.com>
Thanks

Co-authored-by: Quy <quy@nomonkeybiz.com>
@webmasterab webmasterab changed the title Created translatable strings for LocalAdapter.php Created translatable strings for LocalAdapter.php "code review" Jun 25, 2024
@toivo
Copy link
Contributor

toivo commented Jun 30, 2024

I have tested this item 🔴 unsuccessfully on a07d5c2

Tested briefly in Joomla 4.4.6-dev. The language strings should be added also to administrator/language/en-GB/com_media.ini. Value: COM_MEDIA_MOVE_FILE_NOT_POSSIBLE="COM_MEDIA_MOVE_FILE_NOT_POSSIBLE"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

@webmasterab
Copy link
Contributor Author

I have tested this item 🔴 unsuccessfully on a07d5c2Tested briefly in Joomla 4.4.6-dev. The language strings should be added also to administrator/language/en-GB/com_media.ini. Value: COM_MEDIA_MOVE_FILE_NOT_POSSIBLE="COM_MEDIA_MOVE_FILE_NOT_POSSIBLE"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

Thank you for your test.
Too bad this didn't work out.

I understand why you marked it as unsuccessful.

How can I update this request so that I can also put the missing translations in the admin's.
Or should I make another request for this?

@webmasterab
Copy link
Contributor Author

@Quy and @toivo I have adjusted it and now also adjusted the file in administrator/language.
Would you please look and possibly do a check.
Thanks

@toivo
Copy link
Contributor

toivo commented Aug 1, 2024

I have tested this item ✅ successfully on 0b36e42

Tested successfully in Joomla 4.4.6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

@Quy
Copy link
Contributor

Quy commented Aug 8, 2024

I have tested this item ✅ successfully on 2316500


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

1 similar comment
@fgsw
Copy link

fgsw commented Aug 8, 2024

I have tested this item ✅ successfully on 2316500


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

@Quy
Copy link
Contributor

Quy commented Aug 8, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 8, 2024
@webmasterab
Copy link
Contributor Author

@Quy Thanks for merging with 4.4.
However, when I look at that code now, I don't see my adjustments, is that right?

@brianteeman
Copy link
Contributor

it has not been merged yet

@brianteeman
Copy link
Contributor

ah I see the confusion

@Quy has merged the latest changes from core into this pull request in preparation for this pull request to be merged into core

@webmasterab
Copy link
Contributor Author

@brianteeman Thank you for explaining.
I saw that it was merged with joomla-dev4.4 so I thought it worked.
I'm waiting

@laoneo
Copy link
Member

laoneo commented Aug 9, 2024

Before I can merge, you need to resolve the conversation. If it is not fixed and you need to make an adjustment with a new commit, then we need another round of testing.

@webmasterab
Copy link
Contributor Author

webmasterab commented Aug 9, 2024

Before I can merge, you need to resolve the conversation. If it is not fixed and you need to make an adjustment with a new commit, then we need another round of testing.

Found it and solved it.

@laoneo laoneo changed the base branch from 4.4-dev to 5.2-dev September 12, 2024 08:19
@laoneo laoneo changed the title Created translatable strings for LocalAdapter.php "code review" [5.2] Created translatable strings for LocalAdapter.php "code review" Sep 12, 2024
@laoneo
Copy link
Member

laoneo commented Sep 12, 2024

I'v rebased this to 5.2. As soon as 5.2 gets the upmerges from 4.4 we can update this one too and the conflicts will be gone.

@laoneo laoneo removed the PR-4.4-dev label Sep 12, 2024
@Hackwar Hackwar merged commit f104a8c into joomla:5.2-dev Sep 18, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thanks for your contribution @webmasterab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants